-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use boost program_options in example #288
Conversation
Doing this had occurred to me too but I ended up deciding against it, kind of for the reasons you describe that people largely don't like using Boost program options, and the SDK examples are supposed to be usable as kind of cookie cutter copy-paste projects that someone would then build their own code on top of, in which case they probably would just use another argument-parsing library. |
There is prior art for using |
I don't feel strongly about this and don't have context in this repo, one of you needs to make the decision unilaterally |
I think it is @lia-viam's call either way. |
Hahah let's leave this one aside then but thanks for the PR anyway! |
Oh wait just saw @acmorrow 's comment saying we already do this elsewhere! I think we can merge this in that case |
@abe-winter or anyone else, feel free to merge this when the build passes, I just merged |
can you approve? repo is locked to sdk team I think |
What changed
Why
Incidental change while using this example. Not in love with this part of boost, p-ranav/argparse seems to be the modern equivalent, and cmake friendly? (But haven't tried it).
Not sure this is necessary / useful here, feel free to discard if not appropriate for sdk examples.